On Thu, May 26, 2016 at 09:42:48AM -0700, Junio C Hamano wrote: > Duy Nguyen <pclouds@xxxxxxxxx> writes: > > > On Thu, May 19, 2016 at 7:08 AM, Jeff King <peff@xxxxxxxx> wrote: > >> On Wed, May 18, 2016 at 06:43:23PM -0400, Jeff King wrote: > >> > >>> cache.h | 1 + > >>> config.c | 51 +++++++++++++++++++++++++++++++++++++++++--------- > >>> t/helper/test-config.c | 20 ++++++++++++++++++++ > >>> t/t1308-config-set.sh | 23 +++++++++++++++++++++++ > >>> [...] > >>> +test_expect_success 'iteration shows correct origins' ' > >>> + echo "[alias]test-config = !test-config" >.gitconfig && > > > > How about using 'which' to get absolute path for test-config and put > > it here? Then we don't rely on $PATH anymore. > > Don't use which, which is not portable. > > Remind me why we end up running ./test-config instead of > ./bin-wrappers/test-config? Should our tests be running > bin-wrappers early in their $PATH, perhaps? The problem is running test-config inside of a git alias. The bin-wrappers will set the exec-path to the root-level of git's build directory, which the git binary will then stick at the front of the $PATH. So the simplest solution really is: don't do that. The only debate in my mind is whether this is rare enough that it won't bite somebody again in the future, or if we should look into a solution that makes this Just Work. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html