Duy Nguyen <pclouds@xxxxxxxxx> writes: > On Thu, May 19, 2016 at 7:08 AM, Jeff King <peff@xxxxxxxx> wrote: >> On Wed, May 18, 2016 at 06:43:23PM -0400, Jeff King wrote: >> >>> cache.h | 1 + >>> config.c | 51 +++++++++++++++++++++++++++++++++++++++++--------- >>> t/helper/test-config.c | 20 ++++++++++++++++++++ >>> t/t1308-config-set.sh | 23 +++++++++++++++++++++++ >>> [...] >>> +test_expect_success 'iteration shows correct origins' ' >>> + echo "[alias]test-config = !test-config" >.gitconfig && > > How about using 'which' to get absolute path for test-config and put > it here? Then we don't rely on $PATH anymore. Don't use which, which is not portable. Remind me why we end up running ./test-config instead of ./bin-wrappers/test-config? Should our tests be running bin-wrappers early in their $PATH, perhaps? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html