On Thu, Apr 28, 2016 at 08:24:05AM -0700, Jacob Keller wrote: > On Thu, Apr 28, 2016 at 6:36 AM, Jeff King <peff@xxxxxxxx> wrote: > > Commit 14111fc (git: submodule honor -c credential.* from > > command line, 2016-02-29) accidentally wrote $HTTP_URL. It > > happened to work because we ended up with "credential..helper", > > which we treat the same as "credential.helper", applying it > > to all URLs. > > You say "credential.helper" twice here? I think that's confusing. The > patch looks perfectly fine but I am having trouble parsing this > description. 'We end up with X which we treat the same as X"? Note the two dots in the first one. There is no variable $HTTP_URL, so: credential.$HTTP_URL.helper becomes: credential..helper -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html