On Thu, Apr 28, 2016 at 08:17:53AM -0400, Jeff King wrote: > So that case _is_ correct right now. It's just that t5550 isn't testing > the shell script part, which is broken. Probably running "git submodule > update" in the resulting clone would cover that. > > And for the fetch case, we probably just need to be calling > prepare_submodule_repo_env() there, too. So here's a series which fixes sanitizing in the "git-submodule" shell script, along with "git fetch". And cleans up a few things along the way. [1/5]: t5550: fix typo in $HTTPD_URL [2/5]: t5550: break submodule config test into multiple sub-tests [3/5]: submodule: export sanitize GIT_CONFIG_PARAMETERS [4/5]: submodule--helper: move config-sanitizing to submodule.c [5/5]: submodule: use prepare_submodule_repo_env consistently -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html