On Thu, Apr 28, 2016 at 6:36 AM, Jeff King <peff@xxxxxxxx> wrote: > Commit 14111fc (git: submodule honor -c credential.* from > command line, 2016-02-29) accidentally wrote $HTTP_URL. It > happened to work because we ended up with "credential..helper", > which we treat the same as "credential.helper", applying it > to all URLs. You say "credential.helper" twice here? I think that's confusing. The patch looks perfectly fine but I am having trouble parsing this description. 'We end up with X which we treat the same as X"? > > Signed-off-by: Jeff King <peff@xxxxxxxx> > --- > t/t5550-http-fetch-dumb.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/t/t5550-http-fetch-dumb.sh b/t/t5550-http-fetch-dumb.sh > index 48e2ab6..81cc57f 100755 > --- a/t/t5550-http-fetch-dumb.sh > +++ b/t/t5550-http-fetch-dumb.sh > @@ -103,7 +103,7 @@ test_expect_success 'cmdline credential config passes into submodules' ' > test_must_fail git clone --recursive super super-clone && > rm -rf super-clone && > set_askpass wrong pass@host && > - git -c "credential.$HTTP_URL.username=user@host" \ > + git -c "credential.$HTTPD_URL.username=user@host" \ > clone --recursive super super-clone && > expect_askpass pass user@host > ' > -- > 2.8.1.617.gbdccc2d > -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html