On Fri, Feb 26, 2016 at 2:27 AM, David Turner <dturner@xxxxxxxxxxxxxxxx> wrote: > but -Wshadow produces a ton of complaints on the rest of git's > code. We should probably fix those. I know, but what I wrote was meant for new code only (e.g. make refs/lmdb-backend.o CFLAGS=-Wshadow is clean). I think renaming the global env and transaction to the_env and the_transaction probably does the trick. Again, this is controversial whether it's a good thing to do. So your choice. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html