On Thu, Feb 25, 2016 at 11:27 AM, David Turner <dturner@xxxxxxxxxxxxxxxx> wrote: > On Thu, 2016-02-25 at 19:57 +0700, Duy Nguyen wrote: >> A couple of build warnings I found, haven't really read the code yet. >> These two can easily be fixed >> >> refs/lmdb-backend.c: In function 'lmdb_read_raw_ref': >> refs/lmdb-backend.c:554:16: warning: unused variable 'err' [-Wunused >> -variable] >> struct strbuf err = STRBUF_INIT; >> ^ >> refs/lmdb-backend.c: In function 'lmdb_do_for_each_ref': >> refs/lmdb-backend.c:1625:15: warning: unused variable 'c' [-Wunused >> -variable] >> const char *c = resolve_ref_unsafe_submodule(submodule, refname, >> 0, oid.hash, >> ^ >> >> -Wshadow also gives a bunch of warnings, mostly about "transaction" >> and "env". Whether you want to fix them is really up to you. >> -- >> Duy > > Will fix these, thanks. I've now configured my config.mak to do -Wall > again, but -Wshadow produces a ton of complaints on the rest of git's > code. We should probably fix those. It is a proposal for the GSoC microprojects to fix all -Wshadow problems in say one file. Maybe we'll see some activity there :) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html