Re: [PATCH 1/2] Makefile: Use the same source directory for "ln -s" as for "ln" / "cp"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 5, 2015 at 8:23 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:

>> This is wrong.
>>
>> Currently with symlinks you will get installed into bindir something
>> like this:
>>
>>   git
>>   git-tag -> git
>>   git-show -> git
>>
>> etc.
>>
>> With your change you would have
>>
>>   git
>>   git-tag -> /usr/local/libexec/git-core/git
>>   git-show -> /usr/local/libexec/git-core/git
>>
>> And I don't think we want that.  While those absolute path symlinks
>> are technically correct,...
>
> It is not even correct, is it?
>
> When DESTDIR is set to allow you to install into a temporary place
> only so that you can "tar" up the resulting filesystem tree, bindir
> points at the location we need to "cp" the built programs into, i.e.
> inside DESTDIR.

Agreed folks, please disregard this as well as 2/2 of this series.

-- 
Sebastian Schuberth
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]