Re: [PATCH 1/2] Makefile: Use the same source directory for "ln -s" as for "ln" / "cp"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Feb 5, 2015, at 07:51, Sebastian Schuberth wrote:
For consistency, we should use the same source for symbolic links as for
hard links and copies.

Signed-off-by: Sebastian Schuberth <sschuberth@xxxxxxxxx>
---
Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Makefile b/Makefile
index c44eb3a..21f23cb 100644
--- a/Makefile
+++ b/Makefile
@@ -2265,14 +2265,14 @@ endif
        $(RM) "$$bindir/$$p" && \
        test -z "$(NO_INSTALL_HARDLINKS)" && \
        ln "$$bindir/git$X" "$$bindir/$$p" 2>/dev/null || \
-        ln -s "git$X" "$$bindir/$$p" 2>/dev/null || \
+        ln -s "$$bindir/git$X" "$$bindir/$$p" 2>/dev/null || \

This is wrong.

Currently with symlinks you will get installed into bindir something like this:

  git
  git-tag -> git
  git-show -> git

etc.

With your change you would have

  git
  git-tag -> /usr/local/libexec/git-core/git
  git-show -> /usr/local/libexec/git-core/git

And I don't think we want that. While those absolute path symlinks are technically correct, what we have now is much simpler. While there are a number of build-time paths hard-coded into the executables, the binaries work for the most part if you relocate them as a whole. Your change totally breaks that.

-Kyle
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]