"Kyle J. McKay" <mackyle@xxxxxxxxx> writes: >> - ln -s "git$X" "$$bindir/$$p" 2>/dev/null || \ >> + ln -s "$$bindir/git$X" "$$bindir/$$p" 2>/dev/null || \ > > This is wrong. > > Currently with symlinks you will get installed into bindir something > like this: > > git > git-tag -> git > git-show -> git > > etc. > > With your change you would have > > git > git-tag -> /usr/local/libexec/git-core/git > git-show -> /usr/local/libexec/git-core/git > > And I don't think we want that. While those absolute path symlinks > are technically correct,... It is not even correct, is it? When DESTDIR is set to allow you to install into a temporary place only so that you can "tar" up the resulting filesystem tree, bindir points at the location we need to "cp" the built programs into, i.e. inside DESTDIR. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html