Am 17.07.2014 21:00, schrieb Stepan Kasal: > Hi, > >> Karsten Blees <karsten.blees@xxxxxxxxx> writes: >>> I believe we prefer moving code to the right place over forward >>> declarations (IIRC I got bashed for the latter in one of the first rounds >>> of this patch series). If only to justify 'git-blame -M' :-D > > indeed, my position is the same, generally. > > But it turned out that the current ordering is sane, mostly works as it is, > and I needed _only one_ fwd decl to make things compile. This is why I > decided to have things arranged this way. > Fine with me. However, if it *did* compile for you, I wonder where ALLOC_GROW (as of #02/13) and alloc_nr (as of #10/13) came from? Or did we recently remove '#include "cache.h"' from upstream mingw.c? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html