Re: [PATCH] gitk: Comply with XDG base directory specification

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 21, 2014 at 11:10 AM, Paul Mackerras <paulus@xxxxxxxxx> wrote:
>> +    if {![file exists $config_file]} {
>> +     if {![file exists [file dirname $config_file]]} {
>> +         file mkdir [file dirname $config_file]
>> +     }
>> +     # for backward compatability use the old config file if it exists
>> +     if {[file exists "~/.gitk"]} {set config_file "~/.gitk"}
>
> Don't we need to set config_file_tmp here too?

Yeah it's probably best to keep the two files together.

>
> And, do we really want to create the ~/.config/git directory if we are
> using the old-style ~/.gitk as the config file?

Probably not. I'll prepare a new patch restoring the old behaviour.

Regards,
Astril.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]