On Sun, Sep 8, 2013 at 6:45 PM, Jeff King <peff@xxxxxxxx> wrote: > On Sun, Sep 08, 2013 at 06:25:45PM -0500, Felipe Contreras wrote: > >> > And I do not think it is a problem. The point of the function is not to >> > abstract away the idea of comparison. The point is to give a hook for >> > people on systems without "diff -u" to run the test suite. >> >> The point according to whom? I say it's the other way around. > > The point according to 82ebb0b (add test_cmp function for test scripts, > 2008-03-12). I wish I had simply called it test_diff back then, and then > this conversation could have never occurred. So? That's the original intention from the author, it's not the point of the function from the project's point of view, or what the point _should_ be. >> Either way the fact that others are doing it differently doesn't mean >> that's the best way, that would be argumentum ad populum, and mothers >> are keen to remind us that if other kids are jumping the bridge, that >> doesn't mean we should too. > > Did I once say "my way of thinking about it is the best way"? No. I said > "I think it is a matter of preference". I mentioned other systems using > a particular ordering to show that the set of people who prefer it the > other way is non-zero. That doesn't show it they prefer it that way. They could be in the same situation than us, they might prefer it a different way, but they are stuck with what they chose long time ago. > Feel free to respond, but I have no interest in discussing this any > further with you. This thread has become a giant time sink, and I have > nothing else to say on the matter that I have not already said. It's all right, I don't think you were contributing much more than; diff -u does $expect $actual. In case the above gets misconstrued as an insult, it's not meant that way, Jeff said it himself; he cannot depart his view away from the diff -u implementation. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html