John Keeping <john@xxxxxxxxxxxxx> writes: > On Wed, Sep 04, 2013 at 09:47:12AM -0700, Junio C Hamano wrote: >> Jonathan Nieder <jrnieder@xxxxxxxxx> writes: >> >> > test_cmp_rev follows the same order of arguments a "diff -u" and >> > produces the same output as plain "git diff". It's perfectly readable >> > and normal. >> >> This is way off tangent, but I am somewhat sympathetic to Felipe's >> "compare actual with expect", with reservations. > > This isn't an argument either way, but note that JUnit (and NUnit and > PHPUnit) all have assertEquals methods that take the arguments in the > order "expect, actual". I've always assumed that Git's test framework > was imitating that,... No. See 82ebb0b6 (add test_cmp function for test scripts, 2008-03-12). The "test_cmp" was a replacement for "diff -u", and the same order we fed "diff -u", i.e. expect then actual, was carried over. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html