Re: [PATCH 2/2] Move sequencer to builtin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 10, 2013 at 3:32 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Felipe Contreras <felipe.contreras@xxxxxxxxx> writes:
>
>> On Sun, Jun 9, 2013 at 4:39 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>>
>>> One example of killing the entire thread is when I see "This patch
>>> will not be applied" by Felipe in a thread started with his patch.
>>> I understand that it is his way to say "this patch is retracted"
>>> without having to explicitly say that he now understands that
>>> reviews showed why the patch was wrong or that he thanks the
>>> reviewer for enlightening him.
>>
>> You are wrong. There's nothing wrong with the patch.
>> ...
>> I thought you understood that code should speak, but apparently you don't.
>
> That is exactly the point Peff raised (and I agreed with), isn't it?
>
> Bad behaviour (being difficult to work with) has consequences.

It is not bad behavior. It is bad behavior *in your opinion*, an
opinion that wouldn't be shared by other projects, like the Linux
kernel.

> E.g.
> convincing people that it is not worth their time interacting with
> you, especially when there are better things to do like tending to
> other topics, and you lose the chance to show that your patches are
> good when they indeed are (I don't even know if these patches in
> question are good, and I am not going to find out).

You are hurting the Git project by doing that, and our users,
specially our Windows users.

I thought you were a good maintainer. But apparently you would rather
listen to the people that only complain, rather than actual code, that
actually improves things.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]