Re: [PATCH 2/2] Move sequencer to builtin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jun 9, 2013 at 1:32 PM, Ramkumar Ramachandra <artagnon@xxxxxxxxx> wrote:
> Jeff King wrote:
>> I actually think word choice and politeness is only a small part of it,
>> and one that I live without.  It is not just _how_ something is said,
>> but _what_ is said. And sometimes what is said does not lead in a
>> productive direction. I found Thomas's comment here:
>>
>>   http://article.gmane.org/gmane.comp.version-control.git/227053
>>
>> sums up the core of many of the conflicts I've seen on the list.
>
> This is all very good, Jeff.  Various people have expressed what's
> wrong with fc's "demeanour", "tone", and "style of discussion" in
> various different ways at various different points in time.  This goes
> on and on and on with no end in sight. WHAT do we do?

What really puzzles me is that I think discussion and disagreement are
healthy, not only in open source projects, but in any organization; If
everyone always agrees, you know something is really wrong. But if
others think disagreement is not helpful, why do they bother replying
at all? Arguing. And they think their time is better spent not
discussing, but writing code (or something else), why don't they spend
their time that way. Why blame me for their choices?

We disagree, that's fine, move on.

> I'll be frank: I'm a pragmatic person, and I want to see work.
> Despite all this mess, who has shown me the most number of patches
> with some direction?  Felipe.  Who gets the most number of patches
> into git.git, by far?  Felipe.  And who is wasting time theorizing
> about what's wrong with Felipe in various ways?  Everyone else.

Thanks! "Talk is cheap, show me the code."

>> I am less interested in people's feelings than I am in discussions
>> trying to reach a productive position of agreement, rather than turning
>> it into a point by point debate that may no longer have any use for the
>> project (sometimes individual points need to be refuted or discussed, of
>> course, but it is easy to lose sight of the purpose of an email).
>
> Felipe has discussed the {sequencer.c -> builtin/sequencer.c} move
> with a bunch of us (and sent a patch), discussed how to write tests
> properly with me (with a patch), and discussed how ruby can be used to
> call into libgit.a (with code that I'm currently playing with).

Interesting. In case it might help you, this is the extconf.rb I used:

---
ruby/extconf.rb:
#!/usr/bin/env ruby

require 'mkmf'

$INCFLAGS = "-I.. #{$INCFLAGS}"
$CFLAGS += " -DSHA1_HEADER='<openssl/sha.h>'"

# libs
$LOCAL_LIBS += ' ../builtin/lib.a ../libgit.a ../xdiff/lib.a'
$LIBS += ' -lssl -lcrypto -lz'

# make sure there are no undefined symbols
$LDFLAGS += ' -Wl,--no-undefined'

# Create Makefile
dir_config('git')
create_makefile('git')
--

I have to build all the objects with -fPIC though.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]