Re: [PATCH 3/4] {fast-export,transport-helper}: style cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 17, 2013 at 12:14 PM, Matthieu Moy
<Matthieu.Moy@xxxxxxxxxxxxxxx> wrote:
> Felipe Contreras <felipe.contreras@xxxxxxxxx> writes:
>
>> On Fri, May 17, 2013 at 11:56 AM, Matthieu Moy
>> <Matthieu.Moy@xxxxxxxxxxxxxxx> wrote:
>>> Felipe Contreras <felipe.contreras@xxxxxxxxx> writes:
>>>
>>>> THERE IS NO STYLE BREAKAGE.
>>>
>>> Repeating something, and even making it all caps does not make it true.
>>
>> Tell that to Junio. He is also repeating the same.
>
> Junio explained you carefully how the former code was purposely aligning
> stuff and you broke it.

Yeah, and it was purposely adding a space between the parenthesis,
that doesn't mean it's the desired style.

The fact that something is a certain way, or was, doesn't imply it
*should* be that way. Explaining what the code was formerly doing is
no argument, it's merely an observation.

>> I actually provided *evidence*. Did you miss it?
>
> Star-emphasis does not make things true either. Again, you're losing
> your time, and won't lose mine any further.

Of course, because you have no evidence or arguments.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]