On Thu, May 16, 2013 at 11:19 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: > >> I find it extremely annoying that an obviously correct patch is not >> merged... > > A patch that receives "this breaks style" comments *Invalid* "this breaks style" comments, because it doesn't break any style mentioned in Documentation/CodingGuidelines. If somebody dreamt about another style not mentioned in Documentation/CodingGuidelines after drinking too much coffe, that's irrelevant. The only relevant style is the defined style. > and its author > stubbornly refusing to fix what others pointed out, especially when > the patch itself _is_ about style, cannot be "an obviously correct" > patch, can it? The patch makes the code follow Documentation/CodingGuidelines. Period. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html