Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: > On Thu, May 16, 2013 at 11:19 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: >> >>> I find it extremely annoying that an obviously correct patch is not >>> merged... >> >> A patch that receives "this breaks style" comments > > *Invalid* "this breaks style" comments, because it doesn't break any > style mentioned in Documentation/CodingGuidelines. As for more concrete guidelines, just imitate the existing code (this is a good guideline, no matter which project you are contributing to). It is always preferable to match the _local_ convention The document does not spell out all the details, but that does not mean you can ignore what others say and many find a sensible style request. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html