Re: [PATCH 2/2] Use fixed-size integers for .idx file I/O

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Morten Welinder wrote:
- return ntohl(*((unsigned int *) ((char *) index + (24 * mi)))); + return ntohl(*((uint32_t *)((char *)index + (24 * mi))));

Is that pointer gymnastics guaranteed to work?  I.e., how do we know
that we can access an uint32_t (or unsigned) at such an address?

if index is always aligned to a 4-byte boundary, this is safe.  apart from that, the problem already existed.

cheers
 simon

--
Serve - BSD     +++  RENT this banner advert  +++    ASCII Ribbon   /"\
Work - Mac      +++  space for low €€€ NOW!1  +++      Campaign     \ /
Party Enjoy Relax   |   http://dragonflybsd.org      Against  HTML   \
Dude 2c 2 the max   !   http://golden-apple.biz       Mail + News   / \

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]