Junio C Hamano <gitster@xxxxxxxxx> writes: > Jeff King <peff@xxxxxxxx> writes: > >>> @@ -421,6 +443,9 @@ void pp_user_info(const struct pretty_print_context *pp, >>> if (pp->mailmap) >>> map_user(pp->mailmap, &mailbuf, &maillen, &namebuf, &namelen); >>> >>> + if (pp->inline_single && is_current_user(pp, mailbuf, maillen, namebuf, namelen)) >>> + return; >>> + >>> strbuf_init(&mail, 0); >>> strbuf_init(&name, 0); >> >> This makes sense to suppress the user line when it is not necessary. But >> we should probably always be suppressing the Date line, as it is almost >> always useless. > > When I (figuratively) am sending my patch in a discussion, saying > "You could do it this way", on the other hand, I agree that the date > is uninteresting. Just in case somebody is wondering, please s/, on the other hand//; above. I swapped the paragraphs after I wrote them X-<. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html