Re: [PATCH 1/2] shell doc: emphasize purpose and security model

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jonathan Nieder <jrnieder@xxxxxxxxx> writes:

> diff --git a/Documentation/git-shell.txt b/Documentation/git-shell.txt
> index 9b925060..4fe93203 100644
> --- a/Documentation/git-shell.txt
> +++ b/Documentation/git-shell.txt
> @@ -9,25 +9,61 @@ git-shell - Restricted login shell for Git-only SSH access
>  SYNOPSIS
>  --------
>  [verse]
> -'git shell' [-c <command> <argument>]
> +'chsh' -s $(which git-shell) git
> +'git clone' `git@localhost:/path/to/repo.git`
> +'ssh' `git@localhost`

I am wondering if we want to do the following instead of/in addition
to fixing the $(which git-shell).  It is not like we only allow a
single user and its name has to be 'git'.

diff --git a/Documentation/git-shell.txt b/Documentation/git-shell.txt
index 4fe9320..6829ea9 100644
--- a/Documentation/git-shell.txt
+++ b/Documentation/git-shell.txt
@@ -9,9 +9,9 @@ git-shell - Restricted login shell for Git-only SSH access
 SYNOPSIS
 --------
 [verse]
-'chsh' -s $(which git-shell) git
-'git clone' `git@localhost:/path/to/repo.git`
-'ssh' `git@localhost`
+'chsh' -s /path/to/git-shell <user>
+'git clone' `<user>@localhost:/path/to/repo.git`
+'ssh' `<user>@localhost`
 
 DESCRIPTION
 -----------
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]