On Sun, Feb 10, 2013 at 08:14:04PM -0800, Jonathan Nieder wrote: > Jeff King wrote: > > On Sun, Feb 10, 2013 at 05:20:16PM -0800, Jonathan Nieder wrote: > > >> +When run interactively (with no arguments), 'git-shell' will > >> +automatically run `~/git-shell-commands/help` on startup, provided it > >> +exists. If the 'help' command fails then the interactive shell is > >> +aborted. > > > > Doesn't that mean that people who currently do allow interactive access > > and have a ~/git-shell-commands/help (that returns zero) will get > > spammed by its as a motd each time they connect? > > Only interactive connections. That's the existing behavior. Ah, sorry. I misread the patch. I see now that we already run help, and this is just making the exit value significant. In that case, yeah, I think it's fine. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html