Jeff King wrote: > I think what threw me off was reading the documentation part of the > patch, which adds a note that we run "help" on startup, and then > elaborates on the exit value. I didn't realize that the first half was > documenting what already happened. > > Tweaking the third paragraph of the commit message to: Very nice. How about this version? Jonathan Nieder (2): shell doc: emphasize purpose and security guarantees shell: pay attention to exit status from 'help' command Documentation/git-shell.txt | 86 +++++++++++++++++++++++++++++++++++++-------- shell.c | 10 ++++-- 2 files changed, 79 insertions(+), 17 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html