On Fri, Feb 08, 2013 at 10:13:23AM -0800, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > On Fri, Feb 08, 2013 at 06:34:37PM +0100, Matthieu Moy wrote: > > > >> Jeff King <peff@xxxxxxxx> writes: > >> > >> > That seems much cleaner to me. If done right, it could also let people > >> > put: > >> > > >> > CONTRIB_PERL += contrib/mw-to-git/git-remote-mediawiki > >> > >> Actually, you can already do this: > >> > >> SCRIPT_PERL += contrib/mw-to-git/git-remote-mediawiki.perl > >> > >> probably not by design, but it works! > > > > So putting: > > > > ROOT=contrib/mw-to-git > > git-remote-mediawiki: FORCE > > @make -C ../.. SCRIPT_PERL=$(ROOT)/$@.perl $(ROOT)/$@ > > > > in contrib/mw-to-git/Makefile would already work? Neat. > > That essentially is what [v2 2/2] does, no? Yes (this one was cc'd to me, but the others were not, so I read it in isolation). I think Matthieu's series is nicer than just that, though, because it handles the single-file case installation, too, which requires more support from the parent Makefile. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html