On Thu, Feb 07, 2013 at 11:28:31AM -0800, Junio C Hamano wrote: > Matthieu Moy <Matthieu.Moy@xxxxxxx> writes: > > > The configuration of the install directory is not reused from the > > toplevel Makefile: we assume Git is already built, hence just call > > "git --exec-path". This avoids too much surgery in the toplevel Makefile. > > > > git-remote-mediawiki.perl can now "use Git;". > > > > Signed-off-by: Matthieu Moy <Matthieu.Moy@xxxxxxx> > > --- > > Continuing to the comment on 3/4, I wonder if it would be a lot > simpler and more maintainable if you replaced 1/4 to 3/4 with a > smaller patch to the top-level Makefile to teach it to munge > arbitrary path/to/foo.perl to path/to/foo the same way as we do to > other path/tool.perl that are known to the top-level Makefile > (similarly, another target to install the resulting path/to/foo at > an arbitrary place). Then do something like > > all:: > $(MAKE) -C ../.. \ > PERL_SCRIPT=contrib/mw-to-git/git-remote-mediawiki.perl \ > build-perl-script > install:: > $(MAKE) -C ../.. \ > PERL_SCRIPT=contrib/mw-to-git/git-remote-mediawiki.perl \ > install-perl-script > > in this step. That seems much cleaner to me. If done right, it could also let people put: CONTRIB_PERL += contrib/mw-to-git/git-remote-mediawiki or similar into their config.mak, and just get specific contrib bits built and installed along with the rest of git. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html