Re: [PATCH V2] t9810: Do not use sed -i

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



gitster@xxxxxxxxx wrote on Wed, 02 Jan 2013 15:06 -0800:
> Pete Wyckoff <pw@xxxxxxxx> writes:
> 
> > tboegi@xxxxxx wrote on Wed, 02 Jan 2013 00:20 +0100:
> >> sed -i is not portable on all systems.
> >> Use sed with different input and output files.
> >> Utilize a tmp file whenever needed
> >> 
> >> Added missing && at 2 places
> >> 
> >> Signed-off-by: Torsten Bögershausen <tboegi@xxxxxx>
> >
> > One more teensy fix is needed in this hunk, following Junio's
> > comment about redirections going at the end:
> 
> I've already pushed out the previous one on 'pu' after fixing it up
> like this.
> 
> Thanks.  Anything I missed?

I should have guessed that you would just silently fix it.
Thanks!

		-- Pete
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]