tboegi@xxxxxx wrote on Wed, 02 Jan 2013 00:20 +0100: > sed -i is not portable on all systems. > Use sed with different input and output files. > Utilize a tmp file whenever needed > > Added missing && at 2 places > > Signed-off-by: Torsten Bögershausen <tboegi@xxxxxx> One more teensy fix is needed in this hunk, following Junio's comment about redirections going at the end: > @@ -139,7 +140,8 @@ test_expect_success 'scrub ko files differently' ' > cd "$git" && > git config git-p4.skipSubmitEdit true && > git config git-p4.attemptRCSCleanup true && > - sed -i "s/^line4/line4 edit/" fileko && > + sed <fileko "s/^line4/line4 edit/" >fileko.tmp && > + mv -f fileko.tmp fileko && > git commit -m "fileko line4 edit" fileko && > git p4 submit && > scrub_ko_check fileko && I checked that the test still works with your changes. Thanks for the cleanup! Acked-by: Pete Wyckoff <pw@xxxxxxxx> -- Pete -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html