Michael Haggerty <mhagger@xxxxxxxxxxxx> writes: >> OK. As long as the sort order matches the order string-list >> internally uses for its bisection search, it won't be a problem, >> then. > > The sorting is crucial but there is no bisection involved. The sorted > linked-list of references available from the remote and the sorted > string_list of requested references are iterated through in parallel. What I meant was that the order used by string-list is pretty much internal to string-list implementation for its "quickly locate where to insert" bisection. It happens to be the byte value order, I think, but the point is whatever order it is, that has to match the order we keep references in the other data source you walk in parallel to match (i.e. the linked list of references). -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html