This patch series depends on the "Add some string_list-related functions" series that I just submitted. This series is a significant rewrite of v2 based on the realization that the <nr_heads,heads> pair that is passed around in these functions is better expressed as a string_list. I hope you will find that this version is shorter and clearer than its predecessors, even though its basic logic is mostly the same. Sorry for the false starts in v1 and v2 and the extra reviewing work that this will cost. Michael Haggerty (14): t5500: add tests of error output for missing refs t5500: add tests of fetch-pack --all --depth=N $URL $REF Rename static function fetch_pack() to http_fetch_pack() fetch_pack(): reindent function decl and defn Change fetch_pack() and friends to take string_list arguments filter_refs(): do not check the same sought_pos twice fetch_pack(): update sought->nr to reflect number of unique entries filter_refs(): delete matched refs from sought list filter_refs(): build refs list as we go filter_refs(): simplify logic cmd_fetch_pack(): return early if finish_connect() fails fetch-pack: report missing refs even if no existing refs were received cmd_fetch_pack(): simplify computation of return value fetch-pack: eliminate spurious error messages builtin/fetch-pack.c | 169 +++++++++++++++++++------------------------------- fetch-pack.h | 20 ++++-- http-walker.c | 4 +- t/t5500-fetch-pack.sh | 47 +++++++++++++- transport.c | 12 ++-- 5 files changed, 130 insertions(+), 122 deletions(-) -- 1.7.11.3 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html