Re: t5000-tar-tree.sh failing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

Brian Gernhardt wrote:
> Several other test frameworks provide a "skip" method to indicate why  
> we've skipped something.  We could do something similar...
> 
> if skip 'unzip -h' 'tests need unzip'; then
>    # unzip tests
> fi
> 
> skip() {
>   # Have not checked to see if this is anything resembling working code
>   if eval $1 > /dev/null 2>&1; then
>     true
>   else
>     echo "* skipping tests: $2" 1>&2
>     false
>   fi
> }
> 
> Mostly so that skipped tests are obvious, provide a reason, and have  
> a standardized display format.  Again, too busy in actual work to try  
> to do this myself right now, but might hack at it this afternoon if  
> nobody else (hopefully someone more fluent in shell than I am) does.

I'm not sure if (in this case) a missing unzip should be as silent as
you suggest.  The danger is, that s.o. makes a change, runs `make test`
and is then conviced that nothing broke.  So I think that the test
should fail, but with a more descriptive error than it is now. 

The downside is, you need unzip, svn, what ever more to run the test
suite.

Best regards
Uwe

-- 
Uwe Kleine-Koenig

http://www.google.com/search?q=gigabyte+in+bit
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]