Re: t5000-tar-tree.sh failing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Dec 21, 2006, at 9:00 AM, Johannes Schindelin wrote:


Why not enclose the tests in a

	if unzip -h >/dev/null 2>/dev/null; then

		# all these tests

	fi

Hmm?

Several other test frameworks provide a "skip" method to indicate why we've skipped something. We could do something similar...

if skip 'unzip -h' 'tests need unzip'; then
   # unzip tests
fi

skip() {
  # Have not checked to see if this is anything resembling working code
  if eval $1 > /dev/null 2>&1; then
    true
  else
    echo "* skipping tests: $2" 1>&2
    false
  fi
}

Mostly so that skipped tests are obvious, provide a reason, and have a standardized display format. Again, too busy in actual work to try to do this myself right now, but might hack at it this afternoon if nobody else (hopefully someone more fluent in shell than I am) does.

~~ Brian
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]