Johannes Schindelin wrote:
> On Sat, 9 Dec 2006, Nicolas Pitre wrote:
>
>> This doesn't convey much information in the shortlog context.
>> And the perl version did strip it as well.
>
> From the current builtin-shortlog.c:128ff:
>
> if (!strncmp(oneline, "[PATCH", 6)) {
> char *eob = strchr(oneline, ']');
>
> if (eob) {
> while (isspace(eob[1]) && eob[1] != '\n')
> eob++;
> if (eob - oneline < onelinelen) {
> onelinelen -= eob - oneline;
> oneline = eob;
> }
> }
> }
>
> It tries not only to strip "[PATCH]", but also "[PATCH 0/n]" and basically
> every prefix beginning with "[PATCH" and ending in "]". I do not remember
> if I really tested that code, but it should work.
What happens if you have "[PATCH" without closing "]"? Does it work (and
doesn't crash)? Does it strip anything?
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html