Hi,
On Mon, 11 Dec 2006, Jakub Narebski wrote:
> Johannes Schindelin wrote:
>
> > On Sat, 9 Dec 2006, Nicolas Pitre wrote:
> >
> >> This doesn't convey much information in the shortlog context.
> >> And the perl version did strip it as well.
> >
> > From the current builtin-shortlog.c:128ff:
> >
> > if (!strncmp(oneline, "[PATCH", 6)) {
> > char *eob = strchr(oneline, ']');
> >
> > if (eob) {
> > while (isspace(eob[1]) && eob[1] != '\n')
> > eob++;
> > if (eob - oneline < onelinelen) {
> > onelinelen -= eob - oneline;
> > oneline = eob;
> > }
> > }
> > }
> >
> > It tries not only to strip "[PATCH]", but also "[PATCH 0/n]" and basically
> > every prefix beginning with "[PATCH" and ending in "]". I do not remember
> > if I really tested that code, but it should work.
>
> What happens if you have "[PATCH" without closing "]"? Does it work (and
> doesn't crash)? Does it strip anything?
Use the source, Luke!
If "[PATCH" is there, but "]" is not, then eob will be NULL, and nothing
happens.
Well, actually it is not completely true: the code searches for "]" in the
_complete_ commit message (which _is_ terminated by '\0'). But only if it
is found, _and_ it is in the first line, the substring is trimmed away.
Hth,
Dscho
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html