2012/2/5 Thomas Rast <trast@xxxxxxxxxxx>: > Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: > >> Currently bad addresses like 'Foo Bar <foo@xxxxxxx>>' will just be sent >> verbatim -- that's not good; we should either error out, or sanitize >> them. >> >> The following patch adds extra sanitazion so the following >> transformations are performed: >> >> 'Foo Bar <foo@xxxxxxx>' -> 'Foo Bar <foo@xxxxxxx>' >> '"Foo Bar" <foo@xxxxxxx>' -> '"Foo Bar" <foo@xxxxxxx>' >> 'foo@xxxxxxx' -> 'foo@xxxxxxx' >> '<foo@xxxxxxx>' -> 'foo@xxxxxxx' >> 'Foo Bar' -> 'Foo Bar' > > Am I the only one who stared at this for ten seconds, only to then > realize that there is no sanitizing whatsoever going on here? There is: '<foo@xxxxxxx>' -> 'foo@xxxxxxx' >> 'Foo Bar <foo@xxxxxxx>>' -> 'Foo Bar <foo@xxxxxxx>' >> '"Foo Bar" <foo@xxxxxxx>>' -> '"Foo Bar" <foo@xxxxxxx>' >> '<foo@xxxxxxx>>' -> 'foo@xxxxxxx' > > All of these are the same underlying issue. Does your patch fix any > other malformed addresses, or just this particular type? See above. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html