Felipe Contreras <felipe.contreras@xxxxxxxxx> writes:
> Currently bad addresses like 'Foo Bar <foo@xxxxxxx>>' will just be sent
> verbatim -- that's not good; we should either error out, or sanitize
> them.
>
> The following patch adds extra sanitazion so the following
> transformations are performed:
>
> 'Foo Bar <foo@xxxxxxx>' -> 'Foo Bar <foo@xxxxxxx>'
> '"Foo Bar" <foo@xxxxxxx>' -> '"Foo Bar" <foo@xxxxxxx>'
> 'foo@xxxxxxx' -> 'foo@xxxxxxx'
> '<foo@xxxxxxx>' -> 'foo@xxxxxxx'
> 'Foo Bar' -> 'Foo Bar'
Am I the only one who stared at this for ten seconds, only to then
realize that there is no sanitizing whatsoever going on here?
> 'Foo Bar <foo@xxxxxxx>>' -> 'Foo Bar <foo@xxxxxxx>'
> '"Foo Bar" <foo@xxxxxxx>>' -> '"Foo Bar" <foo@xxxxxxx>'
> '<foo@xxxxxxx>>' -> 'foo@xxxxxxx'
All of these are the same underlying issue. Does your patch fix any
other malformed addresses, or just this particular type?
> Basically, we try to check that the address is in the form of
> "Name <email>", and if not, assume it's "email". According to commit
> 155197e[1], the "prhase" should not be empty, so if it is, remove the
^^^^^^
"phrase"
> git-send-email.perl | 14 ++++++++++----
> 1 files changed, 10 insertions(+), 4 deletions(-)
Tests?
--
Thomas Rast
trast@{inf,student}.ethz.ch
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html