Thomas Rast <trast@xxxxxxxxxxx> writes: > Am I the only one who stared at this for ten seconds, only to then > realize that there is no sanitizing whatsoever going on here? > >> 'Foo Bar <foo@xxxxxxx>>' -> 'Foo Bar <foo@xxxxxxx>' >> '"Foo Bar" <foo@xxxxxxx>>' -> '"Foo Bar" <foo@xxxxxxx>' >> '<foo@xxxxxxx>>' -> 'foo@xxxxxxx' > > All of these are the same underlying issue. Does your patch fix any > other malformed addresses, or just this particular type? Just this particular type, as long as the code handles it correctly, would be better than nothing. On the recieving end in mailinfo, I think we also support gitster@xxxxxxxxx (Junio C Hamano) although it does not seem to be used by many people these days (the only one I can remember seeing on this list was merlyn), so we may want to be a bit more consistent between sending and receiving end, though. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html