On Sun, Feb 5, 2012 at 9:57 PM, Thomas Rast <trast@xxxxxxxxxxx> wrote: > Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: > >> Cc: git@xxxxxxxxxxxxxxx, Junio C Hamano <gitster@xxxxxxxxx>, "Brian Gianforcaro" <b.gianfo@xxxxxxxxx>, "Marius Storm-Olsen" <marius@xxxxxxxxxxxxx>, "Junio C Hamano" <junkio@xxxxxxx> > > I hope you noticed that Cc lists like the above really prove my point > that you cannot automate common sense. Your cccmd script apparently > uses the line range in The fact that my script is less than perfect, doesn't mean you *cannot* automate. Again, look at Linux's scripts/get_maintainer.pl. It works * perfectly* fine. >> diff --git a/builtin/blame.c b/builtin/blame.c >> --- a/builtin/blame.c >> +++ b/builtin/blame.c >> @@ -1403,10 +1403,13 @@ > > to determine who to Cc. But in doing so, it dug up an old address for > Junio. It also added Brian whose only fault in all of this was fixing > style of the 'if' you are patching. Yes, it can be improved. But it's still better than nothing. > And on top of that it had absolutely no way of knowing that Cc'ing Peff > would have been a good idea, seeing as you two were involved in an > earlier discussion about this precise bug. > > (Granted, omitting *Peff* doesn't make that much of a difference, since > for all I know he reads every email that crosses this list. But my > point still stands.) That's not the fault of the script; that's what --cc is for. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html