Jonathan Nieder <jrnieder@xxxxxxxxx> writes: > Thanks for tracking this down. Interesting. -Wtype-limits was split > out from the default set of warnings (!) in gcc 4.3 to address > <http://gcc.gnu.org/PR12963>, among other bugs (r124875, 2007-05-20). > > [...] >> --- a/vcs-svn/fast_export.c >> +++ b/vcs-svn/fast_export.c >> @@ -300,7 +300,8 @@ void fast_export_blob_delta(uint32_t mode, >> uint32_t len, struct line_buffer *input) >> { >> long postimage_len; >> - if (len > maximum_signed_value_of_type(off_t)) >> + uintmax_t delta_len = (uintmax_t) len; >> + if (delta_len > maximum_signed_value_of_type(off_t)) >> die("enormous delta"); >> postimage_len = apply_delta((off_t) len, input, old_data, old_mode); > > Is there some less ugly way to write the condition "if this value is > not representable in this type"? > > I guess I could live with something like the following (please don't > take the names too seriously): > ... > What do you think? I'd hold the branch in 'next' for now, until this gets resolved (one possible resolution is to declare Ramsey's patch is good enough for now, and do the follow-up later). -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html