Junio C Hamano <gitster@xxxxxxxxx> writes: > And of course the culprit turns out to be that "cute" expression. > > -- >8 -- > Subject: gitweb: do not use assignment with regexp replace in parameter > > A recent patch made the code to generate a parameter to git_get_projects_list > a bit too cute, by introducing a new variable, assigning a value to it, and > then munging that value with s/// replacement, all in the parameter list. > > The whole expression returns the number of replacements, not the resulting > value in the variable after s/// operation. > > Split them into separate expressions, which also would make the resulting > lines shorter and less taxing on the brain. > > Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx> I've squashed this in to the offending commit and merged the result to the 'next' branch. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html