Junio C Hamano <gitster@xxxxxxxxx> writes: > Jeff King <peff@xxxxxxxx> writes: > >> But as Duy mentions, we have an encoding header. Shouldn't we treat it >> like binary goo until we do reencode_log_message, and _then_ we can >> break it into lines? > > That's sensible. If we go that route, I think the "one allocation of > separate struct commit_buffer pointed from a pointer field in struct > commit to replace the current member 'buffer'" is a reasonable thing > to do. Having given that "sensible" comment, I am not convinced if this is worth it. We are talking about what is left in the ephemeral COMMIT_EDITMSG by the chosen editor, but are there really editors that can _only_ write in UTF-16 and not in UTF-8, and is it worth bending backwards to add support such an editor? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html