Jeff King <peff@xxxxxxxx> writes: > But as Duy mentions, we have an encoding header. Shouldn't we treat it > like binary goo until we do reencode_log_message, and _then_ we can > break it into lines? That's sensible. If we go that route, I think the "one allocation of separate struct commit_buffer pointed from a pointer field in struct commit to replace the current member 'buffer'" is a reasonable thing to do. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html