On Sun, Oct 23, 2011 at 02:46:59AM -0700, Junio C Hamano wrote: > > But when it comes to "Git" Porcelains (e.g. the log family of commands), > > we do assume people do not store random binary byte sequences in commits, > > and we do take advantage of that assumption by splitting each "line" at > > LF, indenting them with 4 spaces, etc. In other words, a commit log in the > > Git context _is_ pretty much text and not arbitrary byte sequence. > > Think what would cutting at a byte whose value is 012 and adding four > bytes whose values are 040 to each of "lines" that formed with such > cutting do to UTF-16 goo, even if it does not contain any NUL byte. As far > as Git Porcelains are concerned, it is no different from random binary > byte sequences. But as Duy mentions, we have an encoding header. Shouldn't we treat it like binary goo until we do reencode_log_message, and _then_ we can break it into lines? -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html