Hi Jonathan, Jonathan Nieder writes: > Ramkumar Ramachandra wrote: >> Jonathan Nieder writes: >>> If "tight coupling" means "builtin/commit.c calls a function declared >>> in sequencer.h", then yes, I think it should be fine. >> >> My bad. I'll first have to figure out a way to expose the todo parsing >> functions (and dependent functions) without touching much else. > > That's the wrong way to go. One right way would be to expose a single > function, representing "here is what to do after successfully making a > commit". Think of it as an invisible built-in post-commit hook > (see githooks(5)). Okay, I don't follow. Wouldn't this function need to parse the todo sheet and figure out how many instructions are left? For that, the todo parsing functions can't be buried in builtin/revert.c, no? Hence I said "expose" them -- or move them to sequencer.c. -- Ram -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html