Re: [PATCH 00/18] GSoC update: Sequencer for inclusion v3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Junio,

Junio C Hamano writes:
> As I already said in the earlier "What's cooking" message, this series is
> getting very closer, and the difference between the last round and this
> seems to be just "allow explicit file to be given to the config writer"
> (with help from Peff) which is very good, and "remove 'Please, do this'".

Right, and some minor commit message improvements.

> Both of which are good. I offhand do not recall if there were other issues
> raised in the previous review round.

No other issues were raised.  I've taken care of all the issues that
were raised by you and Jonathan this iteration too, with a couple of
exceptions:
1. "revert: Remove sequencer state when no commits are pending" isn't
very elegant.  I've decided that the right way to fix this is to
increase the coupling between "git commit" and the sequencer -- I
think this can wait.
2. Jonathan suggested some improvements to "git checkout" behavior in
"reset: Make reset remove the sequencer state".  I think this can wait
too.

Do you think the series is alright otherwise?  I'll post another
iteration of the sequencer momentarily.

Thanks.

-- Ram
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]