Johan Herland <johan@xxxxxxxxxxx> writes: > On Saturday 18 June 2011, Yann Dirson wrote: >> Signed-off-by: Yann Dirson <ydirson@xxxxxxx> >> --- >> notes.c | 24 ++++++++++++++++-------- >> notes.h | 7 +++++++ >> 2 files changed, 23 insertions(+), 8 deletions(-) >> >> [...] >> >> /* >> + * Return a short name for a notes ref, suitable for display to the user. >> + * >> + * No copy is done, the return value is a pointer into the original string. >> + */ >> +const char *notes_ref_shortname(const char *ref); >> + >> +/* > > Please include in the documentation what a NULL return means. > > Otherwise the patch looks OK. It may be just me, but every time somebody says Factorize, I find myself looking for math textbook from middle school days, 12 = 2 * 2 * 3, etc. Could we say Refactor instead pretty please? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html