Re: [PATCH 1/6] Bring notes.c template handling in line with commit.c.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johan Herland <johan@xxxxxxxxxxx> writes:

> On Saturday 18 June 2011, Yann Dirson wrote:
>> Signed-off-by: Yann Dirson <ydirson@xxxxxxx>
>
> Please mention in the commit message that the commit merely replaces 
> write_or_die()/int fd with the corresponding stdio functionality, and that 
> there is no (intended) change in behavior. It was not apparent from your 
> commit message that you had not made any other changes.
>
> Otherwise the patch looks OK.

I had an impression that you would lose a lot of error checking, unless
you are careful, if you go from write_or_die() to stdio.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]