On Saturday 18 June 2011, Yann Dirson wrote: > Signed-off-by: Yann Dirson <ydirson@xxxxxxx> > --- > notes.c | 24 ++++++++++++++++-------- > notes.h | 7 +++++++ > 2 files changed, 23 insertions(+), 8 deletions(-) > > [...] > > /* > + * Return a short name for a notes ref, suitable for display to the user. > + * > + * No copy is done, the return value is a pointer into the original string. > + */ > +const char *notes_ref_shortname(const char *ref); > + > +/* Please include in the documentation what a NULL return means. Otherwise the patch looks OK. ...Johan -- Johan Herland, <johan@xxxxxxxxxxx> www.herland.net -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html