Ramkumar Ramachandra wrote:
> Ramkumar Ramachandra writes:
>>> Ramkumar Ramachandra wrote:
>>>> +++ b/builtin/revert.c
>>>> @@ -603,19 +603,12 @@ static int read_and_refresh_cache(struct replay_opts *opts)
>>>> return 0;
>>>> }
>>>>
>>>> -static int revert_or_cherry_pick(int argc, const char **argv,
>>>> - struct replay_opts *opts)
>>>> +static int pick_commits(struct replay_opts *opts)
>>>> {
[...]
>>>> - setenv(GIT_REFLOG_ACTION, me, 0);
>>>> - parse_args(argc, argv, opts);
>>>> -
>>>> if (opts->allow_ff) {
[...]
>> Nice catch! Yes, GIT_REFLOG_ACTION should be in pick_commits.
>
> Er, I mean in do_pick_commit. Right?
It seems somehow cleaner to set the envvar once in pick_commits,
assuming do_pick_commit is a private function that won't be exported.
But either way sounds fine to me.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html