Hi again,
Ramkumar Ramachandra writes:
> Jonathan Nieder writes:
> > Ramkumar Ramachandra wrote:
> > > --- a/builtin/revert.c
> > > +++ b/builtin/revert.c
> > > @@ -603,19 +603,12 @@ static int read_and_refresh_cache(struct replay_opts *opts)
> > > return 0;
> > > }
> > >
> > > -static int revert_or_cherry_pick(int argc, const char **argv,
> > > - struct replay_opts *opts)
> > > +static int pick_commits(struct replay_opts *opts)
> > > {
> > > struct rev_info revs;
> > > struct commit *commit;
> > > - const char *me;
> > > int res;
> > >
> > > - git_config(git_default_config, NULL);
> > > - me = (opts->action == REVERT ? "revert" : "cherry-pick");
> > > - setenv(GIT_REFLOG_ACTION, me, 0);
> > > - parse_args(argc, argv, opts);
> > > -
> > > if (opts->allow_ff) {
> >
> > I don't see why the caller sets up GIT_REFLOG_ACTION, since the caller
> > is not making the commits. Is there an example where it would use
> > something other than "cherry-pick" or "revert"?
>
> Nice catch! Yes, GIT_REFLOG_ACTION should be in pick_commits.
Er, I mean in do_pick_commit. Right?
-- Ram
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html